Skip to content

Conversation

danimhr
Copy link
Collaborator

@danimhr danimhr commented Jun 3, 2025

This PR implements signature generation for a Wormhole guardian using price update messages from Pythnet.

Copy link
Collaborator

@ali-behjati ali-behjati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Most of my comments are minor and are suggestions. I like you to address them but some of them can be done in subsequent PRs.

rustfmt.toml Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not for this PR but there was a long running debate to remove this format and use standard format for more consistency. We have removed it in pyth-crosschain and i think it's better to remove it here (in another PR)

src/main.rs Outdated
}
}

tokio::spawn(async move {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason you do it in another task?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think unsubscribing is not that important. Just wanted to start the connection asap

@danimhr danimhr merged commit 5aaa580 into main Jun 4, 2025
1 check passed
@danimhr danimhr deleted the feat/sign-message branch June 4, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants